Merged
Conversation
socket.error is a deprecated alias of OSError used on Python versions lower than 3.3. Also cherry pick over the relevant cyclic SocketCAN tests and enable Travis CI for SocketCAN tests on Python 2. Fixes #845
the line can.interfaces.interface gave the error "ModuleNotFoundError: No module named 'can.interfaces.interface' Hence propose to remove 'interfaces'
__getattr__ incorrectly assumes that self._dict always exists. However, if self._dict doesn't exist, the function attempts to call __getattr__ again, which results in infinite recursion when serializing the object via pickle. This fixes the implementation of __getattr__ and adds a test to exercise pickling/unpickling the Message. Fixes #804
hardbyte
requested review from
christiansandberg,
felixdivo,
karlding,
pierreluctg and
zariiii9003
Codecov Report
@@ Coverage Diff @@
## master #887 +/- ##
==========================================
+ Coverage 64.63% 65.85% +1.22%
==========================================
Files 63 63
Lines 5822 5852 +30
==========================================
+ Hits 3763 3854 +91
+ Misses 2059 1998 -61 |
Contributor
|
I see nothing wrong in my application when using the latest beta version. I'm using the PCAN interface. |
pierreluctg
approved these changes
Aug 25, 2020
pierreluctg
requested changes
Aug 25, 2020
Fix iteration in Bus.stop_all_periodic_tasks so tasks are properly stopped. In addition, add a test in order to verify that Cyclic Tasks are correctly stopped when multiple tasks are active on a particular bus. The test is carried out via the SocketCAN interface. Note: This is a squashed cherry pick of the following commits from develop: - 8112d13 - 1aa0bc6 Addresses #634
* Use inter-process mutex to prevent concurrent neoVI device open When neoVI server is enabled, there is an issue with concurrent device open. * Move neoVI open lock to module level * Adding dummy file lock when importing FileLock fails * Grammar fix * Raising more precise API error when set bitrate fails Also calling shutdown before raising exception from the init if the device is opened * Simplified if fd condition in init * Moving filelock to neovi extras_require * Adding comma back * Update CHANGELOG.txt Co-authored-by: Pierre-Luc Tessier Gagné <ptessie3@ford.com>
pierreluctg
approved these changes
Aug 28, 2020
Owner
Author
|
This will automatically publish the release if/when someone else approves the PR. |
Collaborator
|
I currently do not have any CAN hardware at all in my home office. So I can only say that the changes look fine, not that they actually work. |
vector: Skip channels without CAN support
zariiii9003
requested changes
Oct 3, 2020
Collaborator
zariiii9003
left a comment
zariiii9003
left a comment
There was a problem hiding this comment.
I would remove the platform import in setup.py (unless i missed something). Otherwise this looks good.
zariiii9003
approved these changes
Oct 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Would appreciate a few people testing out the beta before we release the (hopefully) final 3.x release.
Happy for any last features or fixes to make it in too.